View Issue Details

IDProjectCategoryView StatusLast Update
0001500SkyChart1-Softwarepublic17-10-02 09:59
ReporterSasa Assigned To 
PrioritylowSeverityminorReproducibilityalways
Status resolvedResolutionfixed 
PlatformLinuxOSKubuntuOS Version14.04
Product Version3.11 SVN 
Target Version5.0 
Summary0001500: ToolBar icon - transparent color missing
DescriptionToolBar icon transparent color missing as seen on attached part of screen shot.

This is particularly unpleasant on anchors icon when is a bit unclear to distinguish the status is down or up.
TagsNo tags attached.

Activities

Sasa

16-02-02 23:17

reporter  

Sasa

16-02-02 23:19

reporter   ~0003262

Last edited: 16-02-02 23:24

Probably another bug in Lazarus. If I do not mistaken, I have reported similar issue long long time ago on Lazarus bugtracker.

Patrick Chevalley

16-02-03 07:56

administrator  

icon_clearlook.jpg (5,089 bytes)   
icon_clearlook.jpg (5,089 bytes)   

Patrick Chevalley

16-02-03 07:57

administrator  

icon_win10.jpg (4,446 bytes)   
icon_win10.jpg (4,446 bytes)   

Patrick Chevalley

16-02-03 08:13

administrator   ~0003263

Last edited: 16-02-03 08:32

I make the icon non transparent voluntarily a few years ago because the transparency make the icon unreadable with some theme color.

I add two screen shot that show how it look on Windows 10 and on Gtk2 with Clearlook theme. Not too bad for me.

I agree the icon need reworking but in this case this must not be based on the current set.
We need to restart on a clean base, with svg source, to make it easy to create icon set of any size.

I not have time to work on that now but everyone can make an icon set and testing is easy as you can change the icon theme in Setup / Display / Colour.

Sasa

16-02-03 09:49

reporter   ~0003264

It is useful, however not important (very low priority). I'm quite happy currently with changed caption info for only anchors icon.

BTW, color theme cannot be changed from the CDC on this particular OS - combo shows only "default" (even there is several themes installed, default used by OS is Oxygen). That is not important at all.

Sasa

17-07-24 16:30

reporter   ~0003927

This may be quite simple to achieve, actually. If you have large size icon source of existed icons can be converted to SVG, or if you already have target SVG source to make missing ones.

Of course, if SVG is fully supported.

Patrick Chevalley

17-07-26 10:14

administrator   ~0003933

Unfortunately I not have svg source for the icon.
They are very old and all I have is the small bitmap in the icon_color folder.
This is why they need to be completely redone.

The problem is there is 120 icon to do and I have no skill or experience to do that.

Sasa

17-07-27 16:17

reporter   ~0003940

There is many sources of free icons on internet. If you find any adequate, please link it and I will try to make some set in free time.

The most SVG sources I have found free contains only flat icons (black and white, mostly).

Mattia Verga

17-07-27 18:12

reporter   ~0003941

Some good starting points can be KDE Oxygen or KDE Breeze iconsets.
There should be also some KStars icons based on those iconsets that can get in handy.

I don't really like the actual KStars icons, but I must admit the black and white icons do a nice job when switching to night mode.

Patrick Chevalley

17-07-29 18:16

administrator   ~0003947

Yes, this KDE icons are a good starting point.

I also checked that bgrabitmap support the svg format. So there is no problem to fill an imagelist of any size.

Sasa

17-07-30 08:14

reporter   ~0003952

Last edited: 17-07-30 08:29

Very well then. I would need just link to concrete SVG source(s), as there is several revisions around, actually.

Then the most of work would be to look old icons list, find and add file names of corresponded from SVG source and additionally make missing ones.

Simple as that, perhaps at most a month of work in quite relax tempo...

Mattia Verga

17-07-30 11:31

reporter   ~0003953

I did a quick test to see how the toolbar would be presented using KDE breeze icons style. See the attached image.

Patrick, Sasa, if you like it I can open a project on github and give you access to work together on the missing icons. If you prefer to create a more colorful iconset, I will go forward myself in parallel, since Skychart can support more than one theme, as far as I know.

Patrick, do you think it would be possibile to name icons with a descriptive name instead of "i84", "i120" etc.?
Screenshot_20170730_111957.png (32,099 bytes)   
Screenshot_20170730_111957.png (32,099 bytes)   

Sasa

17-07-30 23:33

reporter   ~0003954

Mattia,

I do not really prefer such BW icons, as they are quite monotone and rather symbolic (cryptic). But yes, with night vision, they are certainly much better choice.

Thank you, however I'm not certain it is good idea to give me an access to git repository for this task. I prefer to attach here when everything is ready, as I'm programmer, not graphical designer and these missing ones I could create may not be good enough. That also means I will not spend more time on this than simply to make similar missing icons to current ones - then anyone can correct it if find it is not good enough or attach better one.

Software I'm planning to use: Inkscape

Here is the color icons SVG source I have found at first search:
https://github.com/kamalx/oxygen-icons-svg

Several icons I have browsed looks quite good for me - much better than current, that is certain. The license is GNU LGPL 3 - presumable compatible. In any event, I will wait for another source, if it is more suitable.

Patrick Chevalley

17-07-31 07:58

administrator   ~0003956

I find Breeze icons source here:
https://github.com/KDE/breeze-icons

In Breeze the icons for small size are symbolic B/W, but for large size they are full color.
They also have a icons-dark series, inverted for night vision (at least the small size).

I personally like the B/W icons because CdC as many small icons in the toolbar and this give a better uniformity than the colorful ones.

For testing you can convert the svg to png in the CdC Themes directory.

It is a bit difficult to change the icons name to something better because the number correspond to the sequence in the imagelist and this sequence is directly used to assign the image to the button.
Maybe we can add a name as a first extension, like i1.fileopen.png, but this require change in the code.

Patrick Chevalley

17-07-31 08:02

administrator   ~0003957

I miss to add this point:

I think it is important the svg icon convert to a readable image in the range 16x16 to 64x64.
The actual size is 16x16 and it is important to keep it for small screen devices.

Sasa

17-07-31 11:55

reporter   ~0003958

Last edited: 17-07-31 14:25

I have tested a bit Inkscape and it is quite powerful to make B/W and a bit complex full colored icons as well. I have attached two test files made briefly and exported PNGs in several sizes. One use plain B/W (Orion symbol) and second colored (gradient base).

At least in Inkscape, for a bit complex shapes I find suitable minimum of 128 or 256px with line width at least 6-8 (should test at least how it looks for 16 and 64px).

Once svg source is made, it could be use to load by CDC, from which could be converted in desired imagelist and required size. Or can be created conversion tool to convert SVG source(s) to desired icon sizes.

The main doubt here is visibility for 16px symbolic icons in case there is only 64/128/256px SVG source, as can be seen in this test case. However, making several SVG sources for different sizes may be rather demanded.

And regarding transparency. One solution may be following (preserving basic icon transparency):

1. Determining background color of toolbar panel after theme is changed. Additionally, with night vision, another icon set may be used.

2. When SVG is converted, any transparent pixel may be transformed to opaque regarding upper background color. Accordingly, any nearby transparent pixel around non transparent one my be inverted or converted accordingly to avoid any readability problem.

icons_test.zip (17,388 bytes)

Mattia Verga

17-07-31 17:45

reporter   ~0003959

This is what I've done yesterday:
https://github.com/mattiaverga/skychart-breeze-theme

I've focused on 16x16px icons size for the moment. Most of the icons are KDE original, some are edited by me and very few are made by myself (like the "Go to North", etc.).

I also uploaded the renamed png files, so they can be easily tested.

The "night-vision" version is made to be used with a dark toolbar background. In this case I made the icons light grey, because we need the red color for the second status. But maybe we can invert the two colors (default: red, selected color: light grey).

Patrick Chevalley

17-10-02 09:59

administrator   ~0004098

skychart-breeze-theme from Mattia is now the default theme in Skychart. This is available in today beta version.

There is two set of icons for use with dark or light gtk/windows theme. The selection is automatic in the program so the button color selection in Setup/Display is removed.

The button icons are loaded from internal TImagelist resources for speed.
The 16, 22, 32 png are included with the program but they are not used until another theme is selected.

The source SVG is included with the skychart source code in tools/data/Themes/src/
This can be used to make other icons theme if desired.

I close this issue now as this solve the initial button transparency problem.

Issue History

Date Modified Username Field Change
16-02-02 23:17 Sasa New Issue
16-02-02 23:17 Sasa File Added: ToolBar - transparent color missing.jpeg
16-02-02 23:19 Sasa Note Added: 0003262
16-02-02 23:24 Sasa Note Edited: 0003262
16-02-03 07:56 Patrick Chevalley File Added: icon_clearlook.jpg
16-02-03 07:57 Patrick Chevalley File Added: icon_win10.jpg
16-02-03 08:13 Patrick Chevalley Note Added: 0003263
16-02-03 08:13 Patrick Chevalley Status new => acknowledged
16-02-03 08:13 Patrick Chevalley Target Version => 5.0
16-02-03 08:32 Patrick Chevalley Note Edited: 0003263
16-02-03 09:49 Sasa Note Added: 0003264
17-07-24 16:30 Sasa Note Added: 0003927
17-07-26 10:14 Patrick Chevalley Note Added: 0003933
17-07-27 16:17 Sasa Note Added: 0003940
17-07-27 18:12 Mattia Verga Note Added: 0003941
17-07-29 18:16 Patrick Chevalley Note Added: 0003947
17-07-30 08:14 Sasa Note Added: 0003952
17-07-30 08:29 Sasa Note Edited: 0003952
17-07-30 11:31 Mattia Verga File Added: Screenshot_20170730_111957.png
17-07-30 11:31 Mattia Verga Note Added: 0003953
17-07-30 23:33 Sasa Note Added: 0003954
17-07-31 07:58 Patrick Chevalley Note Added: 0003956
17-07-31 08:02 Patrick Chevalley Note Added: 0003957
17-07-31 11:55 Sasa File Added: icons_test.zip
17-07-31 11:55 Sasa Note Added: 0003958
17-07-31 11:56 Sasa Note Edited: 0003958
17-07-31 12:01 Sasa Note Edited: 0003958
17-07-31 14:21 Sasa Note Edited: 0003958
17-07-31 14:25 Sasa Note Edited: 0003958
17-07-31 17:45 Mattia Verga Note Added: 0003959
17-10-02 09:59 Patrick Chevalley Status acknowledged => resolved
17-10-02 09:59 Patrick Chevalley Resolution open => fixed
17-10-02 09:59 Patrick Chevalley Note Added: 0004098