View Issue Details

IDProjectCategoryView StatusLast Update
0001894CCdcielGeneralpublic21-01-14 15:36
Reporterhan Assigned ToPatrick Chevalley  
PrioritynoneSeverityfeatureReproducibilityN/A
Status resolvedResolutionfixed 
Target Version1.0 
Summary0001894: Flexibility in sequence editing while running
DescriptionEditing sequences while the sequence is running could result in sequence abortion.

For myself I have developed the habit to open an second CCDciel program for sequence editing to avoid sequence abort. Separating editing and execution would be more elegant.

The plan for the night is often adapted depending on the sky and seeing conditions and transparency near the horizon. There is nothing else to do in the nightly hours while the automation is working.
TagsNo tags attached.

Relationships

related to 0001881 resolvedPatrick Chevalley Add enable/disable button "Edit plan" dialog 
related to 0001880 assignedPatrick Chevalley Show "time elapsed" and "estimated remaining time" on a sequence 
related to 0002030 assignedPatrick Chevalley Suggestion: assign weight to targets in sequence before running 

Activities

Patrick Chevalley

18-02-08 19:13

administrator   ~0004441

Yes, many functions like editing a running sequence or resuming an interrupted one is not supported at the moment.

My idea is to release a first version 1.0 in this state after I finish the few open issues.

Then for version 2.0 I want to separate the analyses of the sequence from it's execution.
Maybe by filling a database with the individual steps identified in the sequence.
This make it much more easy for further editing or restarting at the first non executed step.

For now (version 1.0) I disable the edition button when the sequence is running to make clear this is not supported:
https://sourceforge.net/p/ccdciel/code/782/

Thomas Jaeger

18-02-11 19:05

reporter   ~0004442

Last edited: 18-02-12 15:50

Hello Patrick,
I was going to type exact the same feature wish as Han, than I saw this existing entry.
While imaging this with ccdciel: http://astrob.in/333054/0/ my sequence stopped, because was changing the plan to do more images. Thanks for taking this in account for version 2.
Thomas

Patrick Chevalley

18-02-16 17:42

administrator   ~0004452

Yes more flexibility is require for that.

What you can safely do for now is to not edit the sequence but make the change for the current step directly in the Capture tool.
This is because when a step start it fill the Capture values, start them and wait for the end. So you can change the number of exposure there.
But this apply only to the current step.

Patrick Chevalley

20-12-08 15:07

administrator   ~0006835

The new sequence code is now merged in master and can be tested.
Be sure to have a backup of the ccdciel user data before to run the new version because the .targets files are modified and compatibility with previous version is not tested.
For those who want to test but cannot compile the source code I put a test version here: https://vega.ap-i.net/tmp/ccdciel/

The following description can look complex at first but this is only because I try to describe every aspect, this is in fact really easy to use.

**** Use of template ****

With this version all the sequence information including the detail of exposure for each step is include in the .targets file.
The .plan file is now a template and is not require to run the sequence, this is only a facility to not always enter the same information.
You can even make a sequence without using any template.

When editing a sequence and the plan for a target is modified, so it no more match the template file, this is indicated by a '*' following the template name.
If the change is saved to file and applied to all the other target in the sequence using the same template, the '*' is removed because they now match the file.
If you later load another sequence that was using the same template all the entries are marked with the '*' because they still use the old definition. If you want to update to the new template, select it in the drop-down list for one target and apply to all the other.

To implement this function, the following new button are available in the sequence editor:
- "Save and apply to targets" to save the template file and apply the modification to all the targets using the same template.
- "Save template" to save the template file but apply the modification only to the selected target.
- "Save template as" the same, only for the selected target, but with a new template name.
- "Delete template" to delete the template file, but this keep all the step definition unchanged in every target.

**** Edit the running sequence ****

With this change to the file format it is now possible to edit a sequence when it is running.
The action the program take to apply the modification depend if you modify the running target or not and how you modify the running step.

If the active target or step is not modified the sequence will just continue after the editor is closed, the new option are used for the future target and step. If a parameter is changed for an already complete step or target it will be used only in the case of a repetition.

If you change the active step but only change the total number of exposure to take or the dithering frequency, the sequence will just continue with the new parameters after you close the editor.
But if you change any of the description, exposure time, frame type, binning, filter, gain or offset, this is considered a new step, the current step is interrupted and the sequence is restarted from the beginning to give you the configured number of exposure with the new parameters.

Similarly when you change the active target, if changing only the repeat count or the autofocus option the sequence will continue. But if changing the object name, the coordinates or the rotator angle the sequence is stopped and restarted to make the full plan with the new target.

Changing the time to start or end the sequence is taken into account only if the sequence is waiting to start. Otherwise you have to stop and restart the sequence to apply the new start/end condition.

The following conditions are required to allow edition of the running sequence:
- the option "Keep completion status" is checked.
- no autofocus or slewing to target is now active. If this is the case just wait it complete.

Camera exposure continue normally during the editing but a new exposure is not started until the editor is closed.

**** Edit another sequence ****

A new "Manage" button in the main sequence interface let you copy, edit or delete any sequence file independently of the currently loaded or running one.
This let you prepare a sequence while another one is running.

han

20-12-08 18:50

reporter   ~0006837

Thanks Patrick. This must have been a very big modification. I will try to test it the next days.

Thomas Jaeger

20-12-08 19:48

reporter   ~0006838

Also thanks, I will try it, but November nights in Germany are always foggy.

>Be sure to have a backup of the ccdciel user data before to run the new version because the .targets files are modified and >compatibility with previous version is not tested.
Under Linux it is the .ccdciel folder?

Patrick Chevalley

20-12-08 20:14

administrator   ~0006839

Thank you for testing. At the moment I only do testing with the simulator because of the bad weather.

Yes on Linux this is ~/.config/ccdciel

han

20-12-14 12:48

reporter   ~0006843

Hello Patrick,

I did test using the simulator "Sky simulator for ASCOM" including slewing astrometry and focusing and this version of CCDCiel works great! This give much more flexibility. I have 4 very minor points in attached .rtf file. Screenshots and .target file are included.

Han
bug list.zip (1,015,039 bytes)

Patrick Chevalley

20-12-15 10:14

administrator   ~0006844

Thank you for the test! I think I can fix all the points.

Just to be sure for point 1 about the pause message. I think the program do the same in previous version and I want to be sure you encounter the same case as me.
The reason it show this pause message is because M1 is already set so it cannot start it, there is a message in the log just before the pause.
The Pause window button label are false, "Continue" must be "Retry" and "Cancel" must be "Next target".
If you click Continue it retry M1 and sure it fail again, the way to continue the sequence is to click Cancel that do the same as "unattended" checked.

So can you look at the log if just before the pause you have a message "Target M1_NGC1952 canceled before start, Stop time 07:15:27 already passed"
07:15:27 is M1 set time at my location for today.
I also look to add this message to the pause window.

Patrick Chevalley

20-12-15 11:19

administrator   ~0006845

This error for point 1 is fixed by:
https://github.com/pchev/ccdciel/commit/1e845684424509043699632fe4b8662ade893d67

See screenshot with the new wait message.

Also if "don't wait" column is checked in the sequence this error message is not show and it go directly to the next target.
retry.png (18,592 bytes)   
retry.png (18,592 bytes)   

Patrick Chevalley

20-12-15 13:38

administrator   ~0006846

About point 2, I make a change to enable/disable the button depending on the sequence status.

When the sequence is not running, Stop and Pause are disabled.
When the sequence is running, Start, Load, New, Reset are disabled.
In addition when running and autofocusing or slewing Edit is disabled.

https://github.com/pchev/ccdciel/commit/9f7fa71c23e6d1b1873875c4e04a195e2fdbe316

Patrick Chevalley

20-12-15 14:17

administrator   ~0006847

Point 3, the status bar.
This message do not refer to the sequence but to the capture step.
So 1/1 for Step2 of M12. This is related to the message "Starting Light exposure 1/1 for 10 seconds" in the log.

For better clarity I replace all the Seq by Capture for this messages:
https://github.com/pchev/ccdciel/commit/3bd0c35b7e4d61ae9e1ecfb1584e172d54b8e67b

Patrick Chevalley

20-12-15 14:20

administrator   ~0006848

For point 1 I also indicate the default action after the timeout instead of Cancel.

So in previous screen shot, now it show: "Next target in 106 seconds"

Patrick Chevalley

20-12-15 14:59

administrator   ~0006849

Point 4, the crash when deleting the running object.
Strange I do a lot of test when the current step is deleted but I not test this one :)
This is fixed by:
https://github.com/pchev/ccdciel/commit/fb00087a45cf08a181cfbd5735999aa1f0308093

I build a new test version 0.9.74-2175 with this changes:
https://vega.ap-i.net/tmp/ccdciel/

han

20-12-15 18:07

reporter   ~0006851

I have tested the latest compiled version and the imaging by sequence worked well!

han

20-12-21 10:24

reporter   ~0006861

Hello Patrick,

I have used this version two nights ago with success and I'm very happy with it. The release on Sourceforge is outstanding. Do you wait for more rigorous testing to be completed?

Patrick Chevalley

20-12-22 10:26

administrator   ~0006862

Thank you Han.

For the release I just wait after New Year to be more available in case of specific issue.

Patrick Chevalley

20-12-30 13:47

administrator   ~0006865

The following two issues where reported in the forum:
https://groups.io/g/ccdciel/message/938 and https://groups.io/g/ccdciel/message/940

- is it intended that in the new implementation the steps-elements naming starts with index 0 and not with index 1 as before?
- when loading a target file containing binnings like 2x2 or 3x3 the template grid within 'Edit target list'-dialog shows '2x1' or '3x1'.

This is now fixed in a new test version 0.9.74-2182:
https://vega.ap-i.net/tmp/ccdciel/

Beware the fix for the first issue break the .targets files made with the previous 0.9.74-2175 test version. The first step of the plan is skipped and an empty step is added at the end. Because very few use this version for real I not want to add an automatic migration functionality.
The solution is to reload the template using the dropdown list in the target list and click "Save and apply to targets".

Patrick Chevalley

21-01-14 15:36

administrator   ~0006894

Closing this issue now 0.9.74 is released.

Issue History

Date Modified Username Field Change
18-02-08 17:31 han New Issue
18-02-08 19:13 Patrick Chevalley Assigned To => Patrick Chevalley
18-02-08 19:13 Patrick Chevalley Status new => assigned
18-02-08 19:13 Patrick Chevalley Target Version => 1.2
18-02-08 19:13 Patrick Chevalley Note Added: 0004441
18-02-11 19:05 Thomas Jaeger Note Added: 0004442
18-02-12 15:50 Thomas Jaeger Note Edited: 0004442
18-02-16 17:42 Patrick Chevalley Note Added: 0004452
18-02-16 18:13 Patrick Chevalley Relationship added related to 0001881
18-02-16 18:13 Patrick Chevalley Relationship added related to 0001880
18-10-23 16:44 Patrick Chevalley Target Version 1.2 => 2.0
18-11-15 23:04 Patrick Chevalley Relationship added related to 0002022
18-11-16 22:05 Patrick Chevalley Relationship added related to 0001978
18-11-19 14:30 Patrick Chevalley Relationship added related to 0002030
19-06-08 18:51 Patrick Chevalley Relationship deleted related to 0002022
19-06-08 18:51 Patrick Chevalley Relationship deleted related to 0001978
20-12-08 15:07 Patrick Chevalley Note Added: 0006835
20-12-08 18:50 han Note Added: 0006837
20-12-08 19:48 Thomas Jaeger Note Added: 0006838
20-12-08 20:14 Patrick Chevalley Note Added: 0006839
20-12-14 12:48 han Note Added: 0006843
20-12-14 12:48 han File Added: bug list.zip
20-12-15 10:14 Patrick Chevalley Note Added: 0006844
20-12-15 11:19 Patrick Chevalley Note Added: 0006845
20-12-15 11:19 Patrick Chevalley File Added: retry.png
20-12-15 13:38 Patrick Chevalley Note Added: 0006846
20-12-15 14:17 Patrick Chevalley Note Added: 0006847
20-12-15 14:20 Patrick Chevalley Note Added: 0006848
20-12-15 14:59 Patrick Chevalley Note Added: 0006849
20-12-15 18:07 han Note Added: 0006851
20-12-21 10:24 han Note Added: 0006861
20-12-22 10:26 Patrick Chevalley Note Added: 0006862
20-12-30 13:47 Patrick Chevalley Note Added: 0006865
21-01-14 15:36 Patrick Chevalley Status assigned => resolved
21-01-14 15:36 Patrick Chevalley Resolution open => fixed
21-01-14 15:36 Patrick Chevalley Target Version 2.0 => 1.0
21-01-14 15:36 Patrick Chevalley Note Added: 0006894