0002188: Propose to remove the old SNR calculation method from the code

ID	Project	Category	View Status	Date Submitted	Last Update

0002188	CCdciel	General	public	19-09-12 17:29	19-09-14 18:02

Reporter	han	Assigned To	Patrick Chevalley
Priority	normal	Severity	minor	Reproducibility	have not tried
Status	resolved	Resolution	fixed
Target Version	1.0

Summary	0002188: Propose to remove the old SNR calculation method from the code
Description	Today I did some comparison between the old and new method for SNR calculation. See the two screen shots . The two SNR methods give about same result but with a lot of variation. I propose to remove the old method. For testing here the next weeks, I have removed the old method and attached the update source code as a zip file. You could use or do it yourself since it is simple. I also modified the presented SNR indication from dB to linear. ASTAP uses the SNR value to separate the bright stars from the faint stars. The new SNR calculation method gives about 20 to 30% more star matches for star rich images. This indicates the bright/faint separation works better using the new SNR calculation method.
Steps To Reproduce	Use attached zip file
Tags	No tags attached.

Date Modified	Username	Field	Change
19-09-12 17:29	han	New Issue
19-09-12 17:29	han	File Added: snr_test 10 seconds exposure M29.png
19-09-12 17:29	han	File Added: snr_test 10 seconds exposure M13.png
19-09-12 17:29	han	File Added: single snr calculation.zip
19-09-14 18:02	Patrick Chevalley	Assigned To	=> Patrick Chevalley
19-09-14 18:02	Patrick Chevalley	Status	new => resolved
19-09-14 18:02	Patrick Chevalley	Resolution	open => fixed
19-09-14 18:02	Patrick Chevalley	Target Version	=> 1.0
19-09-14 18:02	Patrick Chevalley	Note Added: 0005942

han 19-09-12 17:29 reporter	snr_test 10 seconds exposure M29.png (15,011 bytes) snr_test 10 seconds exposure M29.png (15,011 bytes) snr_test 10 seconds exposure M13.png (23,271 bytes) snr_test 10 seconds exposure M13.png (23,271 bytes) single snr calculation.zip (116,803 bytes)

Patrick Chevalley 19-09-14 18:02 administrator ~0005942	Thank you Han. I commit the change so this is more easy for testing. https://github.com/pchev/ccdciel/commit/75f3bf114b6be3fe1be50d1647693784fd182f3f