View Issue Details

IDProjectCategoryView StatusLast Update
0001581SkyChart1-Softwarepublic16-12-13 14:47
ReporterSasa Assigned ToPatrick Chevalley  
PrioritynormalSeverityminorReproducibilityalways
Status resolvedResolutionfixed 
PlatformLinux 32-bitOSKubuntuOS Version16.04
Product Version3.11 SVN 
Target Version4.0Fixed in Version3.11 SVN 
Summary0001581: Double labels with selected body
DescriptionWhen select any body in Solar system and zoom in without locking.

This should be fixed by some recent SVN revision, however it still persists in case without locking the body.

SVN 3364

TagsNo tags attached.

Activities

Sasa

16-12-05 18:32

reporter  

Mars - double labeling.png (110,621 bytes)   
Mars - double labeling.png (110,621 bytes)   

Sasa

16-12-05 18:33

reporter  

Phobos - double labeling.png (83,812 bytes)   
Phobos - double labeling.png (83,812 bytes)   

Sasa

16-12-05 18:47

reporter  

Phobos 2 - double labeling.png (68,332 bytes)   
Phobos 2 - double labeling.png (68,332 bytes)   

Sasa

16-12-05 18:49

reporter   ~0003468

This is quite evident when lock and after few second unlock, for instance Phobos, with system clock running.

Patrick Chevalley

16-12-05 19:20

administrator   ~0003469

This problem is only if you have "Use system time" checked, the label do not duplicate if you zoom at a fixed date.

The problem is that each label is identified by a hash based on the object name and the coordinates. As the coordinates change when you zoom, because the time change, the hash of the new label is different and the deduplication do not work.

One quick solution is to not keep the selection label for moving objects.

Sasa

16-12-06 07:11

reporter   ~0003471

Last edited: 16-12-06 07:14

The focused circle as well should track new position of Phobos, not to stay on center.

Perhaps the easiest solution may be to keep only focused object as a plain pointer and after chart is recalculated to look is it drawn and then just draw the focused circle. And when draw all labels do not draw label of focused body, but do that after drawing the focusing circle. This should also cover all situations, but I did not look in the code to suggest more appropriate solution.

Patrick Chevalley

16-12-06 09:02

administrator   ~0003474

I look more in detail and I think it is possible to automatically search for the object name after drawing the chart for the new time. This will refresh the coordinates and fix the problem.

Patrick Chevalley

16-12-10 17:42

administrator   ~0003487

This is fixed by revision 3371:
https://sourceforge.net/p/skychart/code/3371/

Sasa

16-12-13 10:23

reporter   ~0003506

Last edited: 16-12-13 10:41

Sorry, I have to reopen this.

It usually show fine, but in very small FOV, this problem reappears again.

1. Go close to Mars (9 sec FOV), do not lock on it and selected "Use system time" checkbox
2. Search for Phobos and stay in that combobox field
3. Press ENTER numerous of times with delay of few seconds

Second label show again and again and focusing circle do not follow the body. Attached chart and screenshot

SVN 3379

Sasa

16-12-13 10:24

reporter  

Phobos 3 - double labeling.png (210,569 bytes)   
Phobos 3 - double labeling.png (210,569 bytes)   

Sasa

16-12-13 10:25

reporter  

Patrick Chevalley

16-12-13 14:47

administrator   ~0003507

Yes, here the time was also updated between when the search position is acquired and the redraw of the chart at the searched position.

To more easily fix all this problem I add an option to the Refresh() function to not update then time in some case when "Use system time" is active.
Now the Refresh that is part of Search do not change the date for the chart and there is no more problem.

I take the occasion to also not change the date when zooming with mouse or keyboard, this avoid to loss the satellite when the fov is very small.

Also printed chart are now at the same date as the displayed chart.

Please reopen if you found other function with this problem.

https://sourceforge.net/p/skychart/code/3381/

Issue History

Date Modified Username Field Change
16-12-05 18:32 Sasa New Issue
16-12-05 18:32 Sasa File Added: Mars - double labeling.png
16-12-05 18:33 Sasa File Added: Phobos - double labeling.png
16-12-05 18:47 Sasa File Added: Phobos 2 - double labeling.png
16-12-05 18:49 Sasa Note Added: 0003468
16-12-05 19:20 Patrick Chevalley Note Added: 0003469
16-12-05 19:20 Patrick Chevalley Assigned To => Patrick Chevalley
16-12-05 19:20 Patrick Chevalley Status new => assigned
16-12-06 07:11 Sasa Note Added: 0003471
16-12-06 07:13 Sasa Note Edited: 0003471
16-12-06 07:14 Sasa Note Edited: 0003471
16-12-06 09:02 Patrick Chevalley Note Added: 0003474
16-12-07 18:05 Patrick Chevalley Target Version => 4.0
16-12-10 17:42 Patrick Chevalley Note Added: 0003487
16-12-10 17:42 Patrick Chevalley Status assigned => resolved
16-12-10 17:42 Patrick Chevalley Resolution open => fixed
16-12-10 17:42 Patrick Chevalley Fixed in Version => 3.11 SVN
16-12-13 10:23 Sasa Note Added: 0003506
16-12-13 10:23 Sasa Status resolved => new
16-12-13 10:23 Sasa Resolution fixed => reopened
16-12-13 10:24 Sasa File Added: Phobos 3 - double labeling.png
16-12-13 10:25 Sasa File Added: Phpbps 3 - double labeling.cdc3
16-12-13 10:32 Sasa Note Edited: 0003506
16-12-13 10:40 Sasa Note Edited: 0003506
16-12-13 10:41 Sasa Note Edited: 0003506
16-12-13 14:47 Patrick Chevalley Note Added: 0003507
16-12-13 14:47 Patrick Chevalley Status new => resolved
16-12-13 14:47 Patrick Chevalley Resolution reopened => fixed