View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0001675 | SkyChart | 1-Software | public | 17-03-11 14:34 | 17-03-11 18:01 |
| Reporter | Sasa | Assigned To | Patrick Chevalley | ||
| Priority | normal | Severity | trivial | Reproducibility | have not tried |
| Status | resolved | Resolution | fixed | ||
| Platform | Linux | OS | Lubuntu 32-bit | OS Version | 16.10 |
| Product Version | 3.11 SVN | ||||
| Target Version | 4.0 | Fixed in Version | 3.11 SVN | ||
| Summary | 0001675: Solar System Info - Wrong time step | ||||
| Description | There is something wrong in Solar System info incrementing/decrementing time step. Up to 3 months step seems to be correct, however after that is not. It missing 6 months and I'm not sure about Venus revolution time is correct. I do not have a source currently to suggest changes, however I'm certain they are trivial. | ||||
| Tags | No tags attached. | ||||
|
|
Line around 444 of pu_planetinfo: c := round (d / C_OneYear); This gives 1 year instead 6 month, as is used 31 day for a month. Perhaps to use 30.438 days instead or to use floor instead round here. I'm not certain what is more correct, as I would not make more complications to use exact month days. |
|
|
I agree it is not worth to complicate with exact calendar match here. Using trunc() instead of round() fix the display for "6 month". I also change the year length from sidereal year to julian year, it is more convenient to stay on the same day when incrementing by one year. https://sourceforge.net/p/skychart/code/3564/ Then I replace the values for 3 and 6 month in days because multiply 31 make a large difference. https://sourceforge.net/p/skychart/code/3565 Finally change the planet revolution in days to not depend on Earth year. https://sourceforge.net/p/skychart/code/3566 |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 17-03-11 14:34 | Sasa | New Issue | |
| 17-03-11 15:14 | Sasa | Note Added: 0003714 | |
| 17-03-11 18:01 | Patrick Chevalley | Assigned To | => Patrick Chevalley |
| 17-03-11 18:01 | Patrick Chevalley | Status | new => resolved |
| 17-03-11 18:01 | Patrick Chevalley | Resolution | open => fixed |
| 17-03-11 18:01 | Patrick Chevalley | Fixed in Version | => 3.11 SVN |
| 17-03-11 18:01 | Patrick Chevalley | Target Version | => 4.0 |
| 17-03-11 18:01 | Patrick Chevalley | Note Added: 0003716 |
