View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0001908 | SkyChart | 1-Software | public | 18-02-25 11:19 | 18-10-09 15:34 |
| Reporter | Mattia Verga | Assigned To | Patrick Chevalley | ||
| Priority | normal | Severity | major | Reproducibility | always |
| Status | resolved | Resolution | fixed | ||
| Product Version | 4.0 | ||||
| Target Version | 4.2 | ||||
| Summary | 0001908: Fedora build error | ||||
| Description | I'm trying to rebuild Skychart after Fedora upgraded fpc to 3.0.4 and lazarus to 1.8.0, but I get this error: Compiling bgragrayscalemask.pas bgratext.pas(361,30) Error: Identifier not found "lpNoGUI" bgratext.pas(405,64) Error: Identifier not found "lpNoGUI" bgratext.pas(1261) Fatal: There were 2 errors compiling module, stopping Fatal: Compilation aborted make[3]: *** [Makefile:1250: bgrabitmappack.ppu] Error 1 make[3]: Leaving directory '/builddir/build/BUILD/skychart-4.0-3575-src/skychart/component/bgrabitmap' make[2]: Leaving directory '/builddir/build/BUILD/skychart-4.0-3575-src/skychart/component' make[2]: *** [Makefile:2159: bgrabitmap_all] Error 2 make[1]: *** [Makefile:1702: component_all] Error 2 Here it is the full log: https://kojipkgs.fedoraproject.org//work/tasks/7697/25297697/build.log | ||||
| Tags | No tags attached. | ||||
|
|
As a side note, bgrabitmap in ccdciel builds just fine, but it seems to me that bgragrayscalemask.pas is a newer version in ccdciel than in skychart (even skychart trunk). |
|
|
I compile skychart 4.1 every day with Lazarus 1.8 and fpc 3.04 but I think the bgrabitmap in 4.0 is too old. There is two way to fix it: - wait for the new stable 4.2, I can postpone some new feature to make it quickly. - make a 4.0.1 branch with the new bgra. What is the urgency for you? |
|
|
No urgency, I can simply release the 4.1 svn version in Fedora branches affected (Rawhide and F28). So, bgrabitmap in trunk fixes the problem, doesn't it? Looking in Sourceforge code browser I saw that bgragrayscalemask.pas has not been changed since r3326, but skychart 4.0 was r3575, so I thought it was still outdated... |
|
|
The compilation error is in bgratext.pas. It is at revision 3326 corresponding to version 9.2.2 in 4.0 , but at revision 3613 corresponding to version 9.5 in trunk. The fix is: https://github.com/bgrabitmap/bgrabitmap/commit/5fd32bd7f78aa841c1523aa8f2d518df1111ed6f#diff-e4c79f22c57b4a07d8a2af380d69c4ea Anyway current bgrabitmap version is 9.6.1 and I will update it in both skychart and ccdciel. |
|
|
Bgrabitmap is now updated to version 9.9: https://github.com/pchev/skychart/commit/98be4d104a52c8cbb15de022f48239c41df62ce0 |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 18-02-25 11:19 | Mattia Verga | New Issue | |
| 18-02-25 11:46 | Mattia Verga | Note Added: 0004499 | |
| 18-02-25 12:06 | Patrick Chevalley | Assigned To | => Patrick Chevalley |
| 18-02-25 12:06 | Patrick Chevalley | Status | new => assigned |
| 18-02-25 12:06 | Patrick Chevalley | Note Added: 0004500 | |
| 18-02-25 12:13 | Mattia Verga | Note Added: 0004501 | |
| 18-02-25 13:17 | Patrick Chevalley | Note Added: 0004502 | |
| 18-10-09 15:34 | Patrick Chevalley | Status | assigned => resolved |
| 18-10-09 15:34 | Patrick Chevalley | Resolution | open => fixed |
| 18-10-09 15:34 | Patrick Chevalley | Target Version | => 4.2 |
| 18-10-09 15:34 | Patrick Chevalley | Note Added: 0004932 |
