View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
0001564 | SkyChart | 1-Software | public | 16-11-13 15:18 | 16-11-29 11:48 |
Reporter | sev-2003 | Assigned To | Patrick Chevalley | ||
Priority | normal | Severity | feature | Reproducibility | always |
Status | resolved | Resolution | fixed | ||
Target Version | 4.0 | Fixed in Version | 3.11 SVN | ||
Summary | 0001564: Incorrect RGB color value (Fixed sky color) | ||||
Description | Error in Setup - Display - Sky Color - Fixed Sky Color. Click for change color — Color dialog - select white color (RGB = 255/255/255). Press OK. Open again - RGB 250/250/250. The white color (255/255/255) is not saved. | ||||
Tags | No tags attached. | ||||
related to | 0001563 | resolved | Patrick Chevalley | Add option Negative pallete in Setup - Pictures - DSO Catalog picture |
|
|
|
File: skychart-code-3316-trunk\skychart\fu_config_display.pas line 1748 ... if ColorDialog1.Execute then begin // Check the color is "dark" enough L:=((ColorDialog1.Color and $ff)+((ColorDialog1.Color shr 8) and $ff)+((ColorDialog1.Color shr 16) and $ff)) div 3; if L>251 then ColorDialog1.Color:=RGBToColor(250,250,250); {<-- this line What for?} cplot.SkyColor[tag]:=ColorDialog1.Color; ShowSkyColor; end; ... |
|
Yes this is done voluntarily because the way to set a white background is to click the "Black on white" button in Setup/Display/Color. Then you can change the star and other object color if you want. Doing this way the program know it work with inversed color and this also fix 0001563 by inverting the pictures. Can you confirm you can do what you want this way? |
|
|
|
|
|
In this case, the display incorrectly texts. Look at the picture: standart black-white.png and good black-white.png I can specify the color in skychart.ini bgColor=16777215 Why can not specify the color white (255/255/255) in the program? |
|
|
|
With all the default setting and just click "Black on white" it is not so bad, see cdc_default_white_black.png But I understand you need more configuration than just this button. I look more at the code and find that many of the reason I added this protection are now fixed (by new BGRA rendering). So I make a change to let you set the skycolor to white in rev 3322: https://sourceforge.net/p/skychart/code/3322/ This will be available for testing in next Monday beta version. To activate the change you have to click on the fixed sky color box to select white. Please let me know if this solve your issue. I still have to make intensive testing to be sure this not break other functions, specifically printing. |
|
Thanks, I'll take a look. In "Black on white" is not possible to specify the color of labels. In SkyChart printing does not match the pictures on the screen. And not all the colors are adjusted. So I need to save the image as a PNG (grayscale, white for background). If were possible to customize all of the colors that in the ini file, it would simplify the task. For example as option «color scheme». Thanks for the program! :-) |
|
The first change in revision 3322 is to allow to set the label color and replace by gray only if it's color is equal to the sky color. Yes, you have to print to bitmap to select the option "as on screen", I not put this option on the real printer to avoid to receive a bill for ink cartridge from a distracted user. All the difficulties of this print process is that a few user like you want full control on the output, but the majority just want a black sky on screen and some automatic magic to print with a white sky. It is possible to add an option to save and load all the colors to a file. Can you open another report about that if you are interested. |
|
Rev. 3332 — Ok. :) |
|
Thank you for the confirmation. I not find other problem with this change so I close the issue. |
Date Modified | Username | Field | Change |
---|---|---|---|
16-11-13 15:18 | sev-2003 | New Issue | |
16-11-13 15:18 | sev-2003 | File Added: color250.png | |
16-11-14 10:05 | Patrick Chevalley | Project | CCdciel => SkyChart |
16-11-14 17:41 | sev-2003 | Note Added: 0003395 | |
16-11-24 12:08 | Patrick Chevalley | Relationship added | related to 0001563 |
16-11-24 12:16 | Patrick Chevalley | Note Added: 0003402 | |
16-11-24 12:16 | Patrick Chevalley | Assigned To | => Patrick Chevalley |
16-11-24 12:16 | Patrick Chevalley | Status | new => feedback |
16-11-24 12:16 | Patrick Chevalley | Category | General => 1-Software |
16-11-24 12:17 | Patrick Chevalley | Note Edited: 0003402 | |
16-11-24 13:03 | sev-2003 | File Added: good black-white.png | |
16-11-24 13:03 | sev-2003 | File Added: standart black-white.png | |
16-11-24 13:08 | sev-2003 | Note Added: 0003404 | |
16-11-24 13:08 | sev-2003 | Status | feedback => assigned |
16-11-24 16:37 | Patrick Chevalley | File Added: cdc_default_white_black.png | |
16-11-24 16:53 | Patrick Chevalley | Note Added: 0003424 | |
16-11-24 16:53 | Patrick Chevalley | Severity | crash => feature |
16-11-24 16:53 | Patrick Chevalley | Status | assigned => feedback |
16-11-24 16:53 | Patrick Chevalley | Target Version | => 4.0 |
16-11-24 17:29 | sev-2003 | Note Added: 0003427 | |
16-11-24 17:29 | sev-2003 | Status | feedback => assigned |
16-11-24 18:50 | Patrick Chevalley | Note Added: 0003431 | |
16-11-29 11:17 | sev-2003 | Note Added: 0003449 | |
16-11-29 11:48 | Patrick Chevalley | Note Added: 0003450 | |
16-11-29 11:48 | Patrick Chevalley | Status | assigned => resolved |
16-11-29 11:48 | Patrick Chevalley | Resolution | open => fixed |
16-11-29 11:48 | Patrick Chevalley | Fixed in Version | => 3.11 SVN |