View Issue Details

IDProjectCategoryView StatusLast Update
0001640SkyChart1-Softwarepublic17-02-13 22:37
ReporterSasa Assigned ToPatrick Chevalley  
PrioritynormalSeverityminorReproducibilityhave not tried
Status resolvedResolutionfixed 
PlatformLinux 32-bitOSKubuntuOS Version16.04
Product Version3.11 SVN 
Target Version4.0Fixed in Version3.11 SVN 
Summary0001640: Code simplification
DescriptionThere is many copy and paste code around, which makes maintenance quite difficult. I would suggest some further code cleaning, inserting few nested functions or procedures in order to simplify code as much is possible.

For instance, code in:

Procedure TPlanet.SunRect
...

           +' Ps'+tab+nom+tab
           +'m:'+smagn+tab
           +'diam:'+sdiam+blank+lsec+tab
           +'date:'+date+tab
           +'TT:'+datett;

...

This code is repeated many times with few modifications depending planet. That and similar code can be simplified with a nested function, which parameter may be array (if order is important) or set of info desired for specific object.

TagsNo tags attached.

Activities

Patrick Chevalley

17-02-13 22:37

administrator   ~0003599

Yes, this one is for historical reason and I not remarked it is now all the same and can be simplified.
I will look if I find more of this thing.

Fixed in 3507.
https://sourceforge.net/p/skychart/code/3507/

Issue History

Date Modified Username Field Change
17-02-13 21:53 Sasa New Issue
17-02-13 22:37 Patrick Chevalley Assigned To => Patrick Chevalley
17-02-13 22:37 Patrick Chevalley Status new => resolved
17-02-13 22:37 Patrick Chevalley Resolution open => fixed
17-02-13 22:37 Patrick Chevalley Fixed in Version => 3.11 SVN
17-02-13 22:37 Patrick Chevalley Target Version => 4.0
17-02-13 22:37 Patrick Chevalley Note Added: 0003599