View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0001640 | SkyChart | 1-Software | public | 17-02-13 21:53 | 17-02-13 22:37 |
| Reporter | Sasa | Assigned To | Patrick Chevalley | ||
| Priority | normal | Severity | minor | Reproducibility | have not tried |
| Status | resolved | Resolution | fixed | ||
| Platform | Linux 32-bit | OS | Kubuntu | OS Version | 16.04 |
| Product Version | 3.11 SVN | ||||
| Target Version | 4.0 | Fixed in Version | 3.11 SVN | ||
| Summary | 0001640: Code simplification | ||||
| Description | There is many copy and paste code around, which makes maintenance quite difficult. I would suggest some further code cleaning, inserting few nested functions or procedures in order to simplify code as much is possible. For instance, code in: Procedure TPlanet.SunRect ... +' Ps'+tab+nom+tab +'m:'+smagn+tab +'diam:'+sdiam+blank+lsec+tab +'date:'+date+tab +'TT:'+datett; ... This code is repeated many times with few modifications depending planet. That and similar code can be simplified with a nested function, which parameter may be array (if order is important) or set of info desired for specific object. | ||||
| Tags | No tags attached. | ||||
|
|
Yes, this one is for historical reason and I not remarked it is now all the same and can be simplified. I will look if I find more of this thing. Fixed in 3507. https://sourceforge.net/p/skychart/code/3507/ |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 17-02-13 21:53 | Sasa | New Issue | |
| 17-02-13 22:37 | Patrick Chevalley | Assigned To | => Patrick Chevalley |
| 17-02-13 22:37 | Patrick Chevalley | Status | new => resolved |
| 17-02-13 22:37 | Patrick Chevalley | Resolution | open => fixed |
| 17-02-13 22:37 | Patrick Chevalley | Fixed in Version | => 3.11 SVN |
| 17-02-13 22:37 | Patrick Chevalley | Target Version | => 4.0 |
| 17-02-13 22:37 | Patrick Chevalley | Note Added: 0003599 |
