View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
0001744 | SkyChart | 1-Software | public | 17-07-09 20:52 | 17-07-11 13:35 |
Reporter | Sasa | Assigned To | Patrick Chevalley | ||
Priority | normal | Severity | minor | Reproducibility | have not tried |
Status | resolved | Resolution | fixed | ||
Product Version | 4.1 SVN | ||||
Target Version | 4.2 | Fixed in Version | 4.1 SVN | ||
Summary | 0001744: Solar system information: Active button shape | ||||
Description | If I remember correctly, the active button shape on navigation bar was the same as inactive, just red colored. Now it is red square. | ||||
Tags | No tags attached. | ||||
|
|
|
It seems there is something wrong with alpha channel reading Image1.Picture.Bitmap, after recent BGRA update. Use this instead: procedure Tf_planetinfo.NAV_Coloring(col: TColor; bmp:TBGRABitmap); ... // if p^ <> black then if (p^.red <> 0) or (p^.green <> 0) or (p^.blue <> 0) then p^ := coln; You may as well move image from Image1.Picture to a file and load it from, instead. Then you may remove Image1 completely from lfm. |
|
This look related to ColorToBGRA transparency setting, maybe the default change with last version? Just forcing transparency work: https://sourceforge.net/p/skychart/code/3628/ |
|
This will certainly change in next revision of BGRA, because it is fundamental bug anyway. With alpha channel, correct values are: 0 - Completely transparent 255- Completely opaque That means converting plain 24-bit image to 32-bit should take value 255, not 0, as after this BGRA update is performed. AFAICS, this is the problem in BGRADefaultBitmap: constructor Create(ABitmap: TBitmap; AUseTransparent: boolean = true); override; Then is perhaps better the suggested way, since speed is not critical as temp images are created with form creation and they are quite small. |
|
OK, probably better this way as we not need transparency. I also remove the useless outer loop and commented code, same for NAV_Disable() https://sourceforge.net/p/skychart/code/3629/ |
Date Modified | Username | Field | Change |
---|---|---|---|
17-07-09 20:52 | Sasa | New Issue | |
17-07-09 20:52 | Sasa | File Added: Active button shape.png | |
17-07-10 09:30 | Patrick Chevalley | Assigned To | => Patrick Chevalley |
17-07-10 09:30 | Patrick Chevalley | Status | new => confirmed |
17-07-10 09:30 | Patrick Chevalley | Target Version | => 4.2 |
17-07-10 19:14 | Sasa | Note Added: 0003908 | |
17-07-10 19:14 | Sasa | Note Edited: 0003908 | |
17-07-10 19:18 | Sasa | Note Edited: 0003908 | |
17-07-11 09:59 | Patrick Chevalley | Status | confirmed => resolved |
17-07-11 09:59 | Patrick Chevalley | Resolution | open => fixed |
17-07-11 09:59 | Patrick Chevalley | Fixed in Version | => 4.1 SVN |
17-07-11 09:59 | Patrick Chevalley | Note Added: 0003910 | |
17-07-11 11:31 | Sasa | Status | resolved => new |
17-07-11 11:31 | Sasa | Resolution | fixed => reopened |
17-07-11 11:31 | Sasa | Note Added: 0003911 | |
17-07-11 12:01 | Sasa | Note Edited: 0003911 | |
17-07-11 13:35 | Patrick Chevalley | Status | new => resolved |
17-07-11 13:35 | Patrick Chevalley | Resolution | reopened => fixed |
17-07-11 13:35 | Patrick Chevalley | Note Added: 0003912 |