View Issue Details

IDProjectCategoryView StatusLast Update
0001753SkyChart2-Catalog datapublic17-07-29 22:55
ReporterMattia VergaAssigned ToPatrick Chevalley 
PrioritynormalSeveritytrivialReproducibilityN/A
Status resolvedResolutionfixed 
Product Version 
Target Version4.2Fixed in Version 
Summary0001753: Metainfo.xml files should be placed under metainfo directory
DescriptionThe appdata specification has changed the directory where metainfo.xml files should be placed. Now it's share/metainfo.

I've attached a patch to correct the path installation.
TagsNo tags attached.

Activities

Mattia Verga

17-07-29 18:41

reporter  

metainfo.patch (5,542 bytes)
diff -U 3 -dHrN -- a/install_cat1.sh b/install_cat1.sh
--- a/install_cat1.sh	2016-02-17 14:33:25.000000000 +0100
+++ b/install_cat1.sh	2017-07-29 18:30:07.577478921 +0200
@@ -22,9 +22,9 @@
 
 install -m 755 -d $destdir
 install -m 755 -d $destdir/share
-install -m 755 -d $destdir/share/appdata
+install -m 755 -d $destdir/share/metainfo
 install -m 755 -d $destdir/share/skychart
-install -v -m 644 system_integration/Linux/skychart-data-stars/share/appdata/skychart-data-stars.metainfo.xml $destdir/share/appdata/skychart-data-stars.metainfo.xml
+install -v -m 644 system_integration/Linux/skychart-data-stars/share/metainfo/skychart-data-stars.metainfo.xml $destdir/share/metainfo/skychart-data-stars.metainfo.xml
 
 InstCat catalog_gcvs $destdir/share/skychart
 InstCat catalog_idx  $destdir/share/skychart
diff -U 3 -dHrN -- a/install_cat2.sh b/install_cat2.sh
--- a/install_cat2.sh	2017-01-12 16:32:01.000000000 +0100
+++ b/install_cat2.sh	2017-07-29 18:30:33.625788922 +0200
@@ -22,9 +22,9 @@
 
 install -m 755 -d $destdir
 install -m 755 -d $destdir/share
-install -m 755 -d $destdir/share/appdata
+install -m 755 -d $destdir/share/metainfo
 install -m 755 -d $destdir/share/skychart
-install -v -m 644 system_integration/Linux/skychart-data-dso/share/appdata/skychart-data-dso.metainfo.xml $destdir/share/appdata/skychart-data-dso.metainfo.xml
+install -v -m 644 system_integration/Linux/skychart-data-dso/share/metainfo/skychart-data-dso.metainfo.xml $destdir/share/metainfo/skychart-data-dso.metainfo.xml
 
 InstCat catalog_gcm $destdir/share/skychart
 InstCat catalog_gpn $destdir/share/skychart
diff -U 3 -dHrN -- a/system_integration/Linux/skychart-data-dso/share/appdata/skychart-data-dso.metainfo.xml b/system_integration/Linux/skychart-data-dso/share/appdata/skychart-data-dso.metainfo.xml
--- a/system_integration/Linux/skychart-data-dso/share/appdata/skychart-data-dso.metainfo.xml	2017-01-12 16:32:01.000000000 +0100
+++ b/system_integration/Linux/skychart-data-dso/share/appdata/skychart-data-dso.metainfo.xml	1970-01-01 01:00:00.000000000 +0100
@@ -1,11 +0,0 @@
-<?xml version="1.0" encoding="UTF-8"?>
-<component type="addon">
-  <id>skychart-data-dso</id>
-  <extends>skychart.desktop</extends>
-  <name>Additional Nebulae Catalogs</name>
-  <summary>Standard nebulae catalogs: HyperLeda database; 
-    Lynds Bright Nebulae; Sharpless HII Regions; Barnard Dark Objects; Open Cluster Data; 
-    Globular Clusters in the Milky Way; Galactic Planetary Nebulae.</summary>
-  <metadata_license>CC0-1.0</metadata_license>
-  <project_license>Public Domain</project_license>
-</component>
diff -U 3 -dHrN -- a/system_integration/Linux/skychart-data-dso/share/metainfo/skychart-data-dso.metainfo.xml b/system_integration/Linux/skychart-data-dso/share/metainfo/skychart-data-dso.metainfo.xml
--- a/system_integration/Linux/skychart-data-dso/share/metainfo/skychart-data-dso.metainfo.xml	1970-01-01 01:00:00.000000000 +0100
+++ b/system_integration/Linux/skychart-data-dso/share/metainfo/skychart-data-dso.metainfo.xml	2017-01-12 16:32:01.000000000 +0100
@@ -0,0 +1,11 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<component type="addon">
+  <id>skychart-data-dso</id>
+  <extends>skychart.desktop</extends>
+  <name>Additional Nebulae Catalogs</name>
+  <summary>Standard nebulae catalogs: HyperLeda database; 
+    Lynds Bright Nebulae; Sharpless HII Regions; Barnard Dark Objects; Open Cluster Data; 
+    Globular Clusters in the Milky Way; Galactic Planetary Nebulae.</summary>
+  <metadata_license>CC0-1.0</metadata_license>
+  <project_license>Public Domain</project_license>
+</component>
diff -U 3 -dHrN -- a/system_integration/Linux/skychart-data-stars/share/appdata/skychart-data-stars.metainfo.xml b/system_integration/Linux/skychart-data-stars/share/appdata/skychart-data-stars.metainfo.xml
--- a/system_integration/Linux/skychart-data-stars/share/appdata/skychart-data-stars.metainfo.xml	2016-02-17 14:33:25.000000000 +0100
+++ b/system_integration/Linux/skychart-data-stars/share/appdata/skychart-data-stars.metainfo.xml	1970-01-01 01:00:00.000000000 +0100
@@ -1,11 +0,0 @@
-<?xml version="1.0" encoding="UTF-8"?>
-<component type="addon">
-  <id>skychart-data-stars</id>
-  <extends>skychart.desktop</extends>
-  <name>Additional Star Catalogs</name>
-  <summary>Additional stars catalog down to magnitude 12, variable and 
-    double stars: Tycho 2; General Catalogue of Variable Stars; 
-    Washington Double Stars.</summary>
-  <metadata_license>CC0-1.0</metadata_license>
-  <project_license>Public Domain</project_license>
-</component>
diff -U 3 -dHrN -- a/system_integration/Linux/skychart-data-stars/share/metainfo/skychart-data-stars.metainfo.xml b/system_integration/Linux/skychart-data-stars/share/metainfo/skychart-data-stars.metainfo.xml
--- a/system_integration/Linux/skychart-data-stars/share/metainfo/skychart-data-stars.metainfo.xml	1970-01-01 01:00:00.000000000 +0100
+++ b/system_integration/Linux/skychart-data-stars/share/metainfo/skychart-data-stars.metainfo.xml	2016-02-17 14:33:25.000000000 +0100
@@ -0,0 +1,11 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<component type="addon">
+  <id>skychart-data-stars</id>
+  <extends>skychart.desktop</extends>
+  <name>Additional Star Catalogs</name>
+  <summary>Additional stars catalog down to magnitude 12, variable and 
+    double stars: Tycho 2; General Catalogue of Variable Stars; 
+    Washington Double Stars.</summary>
+  <metadata_license>CC0-1.0</metadata_license>
+  <project_license>Public Domain</project_license>
+</component>
metainfo.patch (5,542 bytes)

Patrick Chevalley

17-07-29 22:55

administrator   ~0003949

Thank you,
I apply the patch in rev 3640:
https://sourceforge.net/p/skychart/code/3640/

Issue History

Date Modified Username Field Change
17-07-29 18:41 Mattia Verga New Issue
17-07-29 18:41 Mattia Verga File Added: metainfo.patch
17-07-29 22:55 Patrick Chevalley Assigned To => Patrick Chevalley
17-07-29 22:55 Patrick Chevalley Status new => resolved
17-07-29 22:55 Patrick Chevalley Resolution open => fixed
17-07-29 22:55 Patrick Chevalley Target Version => 4.2
17-07-29 22:55 Patrick Chevalley Note Added: 0003949