View Issue Details

IDProjectCategoryView StatusLast Update
0002521SkyChart1-Softwarepublic22-04-11 16:15
Reporterhan Assigned To 
PrioritynormalSeveritytweakReproducibilityalways
Status resolvedResolutionfixed 
PlatformPCOSWindowsOS Version10 64bit
Product Version4.3 beta 
Summary0002521: Tweak for u_290.pas
DescriptionAttached a minor tweak to u_290.pas. The changes in procedure readdatabase290 are as follows:

1) Moved check for header_record=false up to a separate repeat/until loop.
2) Changed procedure results from type var to type out.

The reason was that in super rare cases the variable ra2 (in ASTAP) was causing a floating point error because the value was NAN and undefined for calculating delta_ra. It probably will not happen fin case type "var" is used for output but then this mod is just to make it standard.

I haven't compiled the change but they are minor and just typed in.

Han
TagsNo tags attached.

Activities

han

22-04-11 14:08

reporter  

u_290.zip (20,914 bytes)

Patrick Chevalley

22-04-11 16:15

administrator   ~0007513

Thank you Han.

I apply the change: https://github.com/pchev/skychart/commit/b36f7653fca873a723d0e49400e626ca56254a46
It compile and run fine.

Issue History

Date Modified Username Field Change
22-04-11 14:08 han New Issue
22-04-11 14:08 han File Added: u_290.zip
22-04-11 16:15 Patrick Chevalley Status new => resolved
22-04-11 16:15 Patrick Chevalley Resolution open => fixed
22-04-11 16:15 Patrick Chevalley Note Added: 0007513