View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0001151 | SkyChart | 1-Software | public | 13-03-24 23:08 | 14-03-29 17:55 |
| Reporter | livia | Assigned To | Patrick Chevalley | ||
| Priority | normal | Severity | major | Reproducibility | always |
| Status | closed | Resolution | fixed | ||
| Platform | Linux | OS | Debian, Ubuntu | OS Version | Ubuntu 12.10 |
| Product Version | 3.8 | ||||
| Target Version | 3.10 | Fixed in Version | 3.9 SVN | ||
| Summary | 0001151: Export a celestial object to Audela does not work | ||||
| Description | The name of the object does not appear in the audela raquette. I am refering to "pointer un object designe dans carte du ciel" (export from Skychart to Audela) and not "visualiser une carte correspondant a une image affichée dans Audela" (import to Skychart from Audela, which still works). | ||||
| Additional Information | Audela version: 2.0.0 Server Skychart: 127.0.0.1 port 3292 | ||||
| Tags | No tags attached. | ||||
|
|
I confirm the problem but I think this must be fixed in Audela, not Skychart. Audela use the command GETMSGBOX at this place (Telescope tool, Chart button). The response to this command is exactly the same in Skychart version 3.8 and 3.6: GETMSGBOX OK! AR: 00h09m50.96s DE:+59°13'28.2" Etoile: TYC 3664-1985-1 Magnitude visuelle: 2.30 Indice de couleur: 0.33 Circumpolaire Culmination: 13h13m But Audela 2.0 show this message in the terminal box: # ::carte::gotoObject msg=can't read "objName": no such variable |
|
|
it seems that the problem is the language. Using Cartes du Ciel in the French system works (except for the catalog UCAC4). |
|
|
Right! Bellow are some example of what skychart return in the working and not working case. Audela look very sensitive to every text string. For example it no more work if I replace AR by RA in French. But it not work if I just replace RA by AR in English. I also not understand why UCAC4 do not work. Because of the too long name? I let the problem open for reference but the code is to be fixed in Audela. English (do not work): GETMSGBOX OK! RA: 05h35m18.40s DE:+22°01'23.4" Bright nebula: M 1 Magnitude: 8.40 Dimension: 8.0 x 4.0 ' Name: NGC 1952 Rise: 9h59m Culmination: 17h42m Set: 1h28m GETMSGBOX OK! RA: 05h27m08.36s DE:+28°36'59.8" Star: Bet Tau Visual magnitude: 1.65 Common name:Alnath HD:35497 Rise: 9h12m Culmination: 17h34m Set: 2h00m French (work): GETMSGBOX OK! AR: 05h35m18.40s DE:+22°01'23.4" Nébuleuse brillante: M 1 Magnitude: 8.40 Dimension: 8.0 x 4.0 ' Nom: NGC 1952 Lever: 9h59m Culmination: 17h42m Coucher: 1h28m GETMSGBOX OK! AR: 05h27m08.36s DE:+28°36'59.8" Etoile: Bet Tau Magnitude visuelle: 1.65 Nom commun:Alnath HD:35497 Lever: 9h12m Culmination: 17h34m Coucher: 2h00m French (do not work): GETMSGBOX OK! AR: 06h43m59.97s DE:+10°41'08.4" Etoile: UCAC4-504-029410 Magnitude visuelle: 14.01 Indice de couleur: 1.82 Lever: 12h03m Culmination: 18h50m Coucher: 1h42m |
|
|
audela-cdc3.patch (1,843 bytes)
Index: gui/audace/plugin/chart/carteducielv3/carteducielv3.tcl
===================================================================
--- gui/audace/plugin/chart/carteducielv3/carteducielv3.tcl (revision 9288)
+++ gui/audace/plugin/chart/carteducielv3/carteducielv3.tcl (working copy)
@@ -400,9 +400,9 @@
# Description de l'interface Audela / CarteDuCiel
# -------------------------------------
# Requete TCP envoyee a CarteDuCiel :
- # puts socket "GETMSGBOX"
- # Reponse DDE retournee par CarteDuCiel :
- # ligne : position du centre et champ de vision de la carte
+ # puts socket "GETSELECTEDOBJECT"
+ # Reponse retournee par CarteDuCiel :
+ # ligne : dernier objet selectione sur la carte
#
# exemple de reponse :
# ligne : OK!\n14h15m39.70s +19°10'57.0" * HR 5340 HD124897 Fl: 16 Ba:Alp const:Boo mV:-0.04 b-v: 1.23 sp: K1.5IIIFe-0.5 pm:-1.093 -1.998 ;ARCTURUS; Haris-el-sema
@@ -514,7 +514,12 @@
variable private
global caption
- set result [ sendRequest "GETMSGBOX" ]
+ #--- nouvelle commande depuis la version 3.9, retourne la meme chaine qu'avant 3.6
+ set result [ sendRequest "GETSELECTEDOBJECT" ]
+ if { $result == "Failed! Bad command name" } {
+ #--- ancienne commande jusqu'a 3.8. ne marche que si CarteDuCiel est en français
+ set result [ sendRequest "GETMSGBOX" ]
+ }
if { $result == "" } {
return ""
}
@@ -529,7 +534,7 @@
set magnitude ""
scan $ligne "%s %s %s %s %\[^\r\] " cr ra dec objType detail
if { $ra == "AR:" } {
- # ::console::disp "CdC V3.6 et +. \n"
+ # ::console::disp "CdC V3.6 et V3.8 \n"
scan $ligne "%s %s %s %s %s %\[^\r\] " cr AR ra dec objType detail
set dec [ string range $dec 3 end ]
}
|
|
|
OK, I think I find a way to solve the problem. Revision 2482 add a new command to CdC that return the same string as before version 3.6. http://sourceforge.net/p/skychart/code/2482/ The attached patch change the Audela interface to use the new command. With this two change it work in French and English. The Skychart beta version with the change will be available later today from: http://www.ap-i.net/skychart/en/development_version I will take a look how to fix the UCAC4 problem too. |
|
|
audela-cdc3-2.patch (3,518 bytes)
Index: gui/audace/plugin/chart/carteducielv3/carteducielv3.tcl
===================================================================
--- gui/audace/plugin/chart/carteducielv3/carteducielv3.tcl (revision 9288)
+++ gui/audace/plugin/chart/carteducielv3/carteducielv3.tcl (working copy)
@@ -400,9 +400,9 @@
# Description de l'interface Audela / CarteDuCiel
# -------------------------------------
# Requete TCP envoyee a CarteDuCiel :
- # puts socket "GETMSGBOX"
- # Reponse DDE retournee par CarteDuCiel :
- # ligne : position du centre et champ de vision de la carte
+ # puts socket "GETSELECTEDOBJECT"
+ # Reponse retournee par CarteDuCiel :
+ # ligne : dernier objet selectione sur la carte
#
# exemple de reponse :
# ligne : OK!\n14h15m39.70s +19°10'57.0" * HR 5340 HD124897 Fl: 16 Ba:Alp const:Boo mV:-0.04 b-v: 1.23 sp: K1.5IIIFe-0.5 pm:-1.093 -1.998 ;ARCTURUS; Haris-el-sema
@@ -514,7 +514,12 @@
variable private
global caption
- set result [ sendRequest "GETMSGBOX" ]
+ #--- nouvelle commande depuis la version 3.9, retourne la meme chaine qu'avant 3.6
+ set result [ sendRequest "GETSELECTEDOBJECT" ]
+ if { $result == "Failed! Bad command name" } {
+ #--- ancienne commande jusqu'a 3.8. ne marche que si CarteDuCiel est en français
+ set result [ sendRequest "GETMSGBOX" ]
+ }
if { $result == "" } {
return ""
}
@@ -529,7 +534,7 @@
set magnitude ""
scan $ligne "%s %s %s %s %\[^\r\] " cr ra dec objType detail
if { $ra == "AR:" } {
- # ::console::disp "CdC V3.6 et +. \n"
+ # ::console::disp "CdC V3.6 et V3.8 \n"
scan $ligne "%s %s %s %s %s %\[^\r\] " cr AR ra dec objType detail
set dec [ string range $dec 3 end ]
}
@@ -597,6 +602,7 @@
return ""
} else {
#--- j'extrais les coordonnees du detail de la ligne2
+ set objName ""
set usualName ""
set bsc ""
set ba ""
@@ -691,11 +697,18 @@
set tyc [string trim [lindex [split [string range $detail $index end ]] 1]]
set tyc "TYC$tyc"
}
- set index [string first "HIP" $detail]
+ set index [string first "HIP:" $detail]
if { $index >= 0 } {
- #--- j'extrais la chaine apres HIP
- set hip [string trim [lindex [split [string range $detail $index end ]] 1]]
- set hip "HIP$hip"
+ #--- j'extrais la chaine HIP:xxxx
+ set hip [lindex [split [string range $detail $index end ]] 0]
+ set hip [string map {":" ""} $hip ]
+ } else {
+ set index [string first "HIP" $detail]
+ if { $index >= 0 } {
+ #--- j'extrais la chaine apres HIP
+ set hip [string trim [lindex [split [string range $detail $index end ]] 1]]
+ set hip "HIP$hip"
+ }
}
set index [string first "3UC" $detail]
if { $index >= 0 } {
@@ -863,6 +876,12 @@
}
}
+ #-- Si on n'a pas trouvé un catalogue connu on prend le premier mot de $detail qui est le nom par défaut
+ if { $objName == "" } {
+ ::console::disp "objName par defaut\n"
+ scan $detail "%s\ \[^\r\] " objName
+ }
+
::console::disp "CDC result objName=$objName\n"
::console::disp "CDC result ra=$ra\n"
::console::disp "CDC result dec=$dec\n"
|
|
|
audela-cdc3-2.patch also fix UCAC4 and the default XHIP star catalog. |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 13-03-24 23:08 | livia | New Issue | |
| 13-03-29 14:54 | Patrick Chevalley | Note Added: 0002485 | |
| 13-03-29 14:54 | Patrick Chevalley | Assigned To | => Patrick Chevalley |
| 13-03-29 14:54 | Patrick Chevalley | Status | new => resolved |
| 13-03-29 14:54 | Patrick Chevalley | Resolution | open => no change required |
| 13-03-29 19:59 | livia | Note Added: 0002488 | |
| 13-03-29 19:59 | livia | Status | resolved => feedback |
| 13-03-29 19:59 | livia | Resolution | no change required => reopened |
| 13-03-29 22:40 | Patrick Chevalley | Note Added: 0002489 | |
| 13-03-30 12:16 | Patrick Chevalley | File Added: audela-cdc3.patch | |
| 13-03-30 12:22 | Patrick Chevalley | Note Added: 0002490 | |
| 13-03-30 12:22 | Patrick Chevalley | Fixed in Version | 0.3.0 => 3.9 SVN |
| 13-03-30 12:22 | Patrick Chevalley | Target Version | 0.3.0 => 3.10 |
| 13-03-30 12:22 | Patrick Chevalley | Status | feedback => resolved |
| 13-03-30 12:22 | Patrick Chevalley | Resolution | reopened => fixed |
| 13-03-30 14:36 | Patrick Chevalley | File Added: audela-cdc3-2.patch | |
| 13-03-30 14:36 | Patrick Chevalley | Note Added: 0002491 | |
| 14-03-29 17:55 | Patrick Chevalley | Status | resolved => closed |
