View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
0001495 | SkyChart | 1-Software | public | 16-02-01 20:17 | 16-02-13 15:57 |
Reporter | Mattia Verga | Assigned To | Patrick Chevalley | ||
Priority | normal | Severity | minor | Reproducibility | always |
Status | resolved | Resolution | fixed | ||
Product Version | 3.11 SVN | ||||
Target Version | 4.0 | Fixed in Version | 3.11 SVN | ||
Summary | 0001495: Make rise and set time to take account of refraction parameters | ||||
Description | While comparing sunrise and sunset times provided by Skychart Calendar with pyephem scripts I noticed a strange behaviour: - with "Draw the apparent depressed horizon line" set to OFF and default settings of Atmosferic refraction and altitude = 0, I get (for example) a sunrise time of 08h03m08s but the Sun is not right at horizon line (screenshot 1) - maintaining "Draw the apparent depressed horizon line" set to OFF, changing observer altitude setting do nothing. Changing Atmosferic refraction settings, Sun's position change on the chart, but Calendar sunrise time remains the same (screenshot 2) - with "Draw the apparent depressed horizon line" set to ON and default settings of Atmosferic refraction and altitude = 0, I get a different sunrise time of 08h03m44s (why?) but the Sun still is not right at horizon line (screenshot 3) - with "Draw the apparent depressed horizon line" set to ON, changing observer altitude setting change Sun position on the chart and sunrise time to 08h01m43s, but again Sun is not right at horizon on the chart (screenshot 4) - with "Draw the apparent depressed horizon line" set to ON, changing Atmosferic refraction settings also move Sun's position on chart and change sunrise time to 08h01m53s In brief: with "Draw the apparent depressed horizon line" set to OFF, Calendar doesn't take into account atmosferic refraction and observer altitude settings when calculates rise and set times, but uses some default parameters that aren't the defaults used in observatory settings. | ||||
Tags | No tags attached. | ||||
|
|
|
|
|
|
|
|
|
Mattia, I agree there is some over simplification in the code here. I make improvement to how the Sun is draw near the horizon but this was not reported to the rise/set computation. I need to replace code in cu_planet, between row 2655 and 2665. |
|
The change are in revision 3228 and 3229. Depressed horizon, temperature and pressure are now taken into account to compute the rise/set time. The rise/set time are now displayed with 1 second precision instead of 1 minute. http://sourceforge.net/p/skychart/code/3228/ http://sourceforge.net/p/skychart/code/3229/ |
|
I think there's still something wrong: - now with "depressed horizon" turned off, changing observer altitude slightly change rise and set time (without moving the horizon line); - with "depressed horizon" turned on, Sun's position on the chart on the rise or set time does not correspond neither to horizon or depressed horizon. Also seems that increasing the observer elevation postpone sunrise time instead of move up |
|
It look like you need to open and close the observatory settings two time for the change to take effect, otherwise the change is only partial and this give incorrect result. Can you try if reopening the observatory setting and click OK again fix the problem. I will look to fix what is do in wrong order after changing this settings. |
|
The calendar was updated before the new refraction constant are computed. This is fixed by 3235 and 3236. https://sourceforge.net/p/skychart/code/3235/ https://sourceforge.net/p/skychart/code/3236/ |
Date Modified | Username | Field | Change |
---|---|---|---|
16-02-01 20:17 | Mattia Verga | New Issue | |
16-02-01 20:17 | Mattia Verga | File Added: screenshot1.png | |
16-02-01 20:17 | Mattia Verga | File Added: screenshot2.png | |
16-02-01 20:17 | Mattia Verga | File Added: screenshot3.png | |
16-02-01 20:17 | Mattia Verga | File Added: screenshot4.png | |
16-02-02 09:01 | Patrick Chevalley | Note Added: 0003255 | |
16-02-02 09:01 | Patrick Chevalley | Assigned To | => Patrick Chevalley |
16-02-02 09:01 | Patrick Chevalley | Status | new => assigned |
16-02-02 09:01 | Patrick Chevalley | Target Version | => 4.0 |
16-02-02 09:01 | Patrick Chevalley | Summary | => Make rise and set time to take account of refraction parameters |
16-02-04 10:47 | Patrick Chevalley | Note Added: 0003272 | |
16-02-04 10:47 | Patrick Chevalley | Status | assigned => resolved |
16-02-04 10:47 | Patrick Chevalley | Resolution | open => fixed |
16-02-04 10:47 | Patrick Chevalley | Fixed in Version | => 3.11 SVN |
16-02-13 14:44 | Mattia Verga | Note Added: 0003280 | |
16-02-13 14:44 | Mattia Verga | Status | resolved => new |
16-02-13 14:44 | Mattia Verga | Resolution | fixed => reopened |
16-02-13 14:50 | Mattia Verga | Note Edited: 0003280 | |
16-02-13 15:18 | Patrick Chevalley | Note Added: 0003281 | |
16-02-13 15:18 | Patrick Chevalley | Status | new => assigned |
16-02-13 15:57 | Patrick Chevalley | Note Added: 0003282 | |
16-02-13 15:57 | Patrick Chevalley | Status | assigned => resolved |
16-02-13 15:57 | Patrick Chevalley | Resolution | reopened => fixed |