View Issue Details

IDProjectCategoryView StatusLast Update
0002068SkyChart1-Softwarepublic19-03-02 11:07
ReporterSasa Assigned ToPatrick Chevalley  
PrioritynormalSeverityminorReproducibilityalways
Status resolvedResolutionfixed 
PlatformLinuxOSUbuntu 64-bitOS Version18.10
Product Version4.1 SVN 
Target Version4.2Fixed in Version4.1 SVN 
Summary0002068: Text visibility issues for TEdit
DescriptionOn many pages there is a problem of text visibility. They are mostly cut off for TEdit (as attached) or latest Ubuntu distro (18.10, gtk2), perhaps may other.

I believe that was the problem in the past and I know it is hard to manage that on many different platforms and OSes, however I also believe that may be solved generically. For instance if keep default font name and size for some widely uses OSes, widgetsets and similar.
TagsNo tags attached.

Activities

Sasa

19-02-02 16:48

reporter  

Patrick Chevalley

19-02-02 17:35

administrator   ~0005293

It look like you use the Adwaita Gtk theme.
The real question is why this theme put as much blank space around the text in the edit control, it need almost three time the font height...
So the problem is not the font size but the extra space need by the edit control.
This is not a Lazarus issue because I see the same for phd2 that is build with wxwidgets.

I normally avoid to use this theme and use Breeze or no theme at all because this give me control size that are much more compatible with Windows.
But I will try to resize some text control to match this theme and look if it is not too bad on Windows.

Patrick Chevalley

19-02-02 17:55

administrator   ~0005294

I think I have a solution by using Constraints.MaxHeigth.
Now I have to update every edit control.

Patrick Chevalley

19-02-02 19:28

administrator   ~0005296

For me this change fix the problem:
https://github.com/pchev/skychart/commit/34c1cd2b1182a778d9ef035280624ef67678c8c2

Can you try and confirm ?

Sasa

19-02-02 20:15

reporter   ~0005297

Last edited: 19-02-02 20:18

Unfortunately, all seems to remain the same in pixel as before change.

I did not set any specific theme myself, actually it is theme by default or set automatically after installing some package...

After I installed gnome tweaks, I can see now "Appearance" tab and here is all selected to "Yaru", for which I never heard before...

Sasa

19-02-02 20:46

reporter   ~0005298

Last edited: 19-02-02 20:52

After I have set "Interface Text" from gnome tweaks to Font size 8, that forced CDC to show date completely.

BTW, all is set to 11, except for monospace text which is 13.

Sasa

19-02-02 20:52

reporter  

Patrick Chevalley

19-02-02 22:33

administrator   ~0005299

Yaru is the new Ubuntu default theme.

But I think the remaining issue is because the font size is 11, but with my Kubuntu it is 10 by default.
This is a small difference but this may make some truncation.

By default CdC resize itself to adjust for different font size but I have a test to avoid unnecessary resize if the difference is small. The limit was set to 10%, this make the program to not resize when changing from 10 to 11.
I commit a modification to change the limit to 2% so it resize in this case. For me this fix the problem when running whit a font size of 11.

Can you try with this change? also be sure in Setup/General/General the option "Adjust window size for the screen dpi" is checked,

Sasa

19-02-02 23:38

reporter  

Sasa

19-02-02 23:38

reporter   ~0005300

That seems to fix the issue. Of course, some minor component resizing or relocation is need, but all seems to be fine for this form now.

BTW, "Adjust..." checkbox is set by default, thus noting is changed.

Sasa

19-02-03 16:38

reporter   ~0005313

Observatory form seem to be broken as well.

Sasa

19-02-03 16:39

reporter  

Patrick Chevalley

19-02-03 17:04

administrator   ~0005314

Thank you.
I replace the text in the combobox by only N/S E/W so this let more space to resize the other box:
https://github.com/pchev/skychart/commit/535f10b1d2629814c0b979bab49d27df069a292c

Patrick Chevalley

19-02-06 13:50

administrator   ~0005339

I close the issue but please reopen if you found another problem.

Sasa

19-02-26 21:45

reporter   ~0005443

I have found similar problem in "Observatory database" form.

Patrick Chevalley

19-02-27 16:20

administrator   ~0005444

Thank you.

This is fixed:
https://github.com/pchev/skychart/commit/7e53dbc5c05e802b56a955aac16c8609448a3417

Sasa

19-03-02 07:13

reporter   ~0005446

When use any online source for DSO images, on download is as well notable similar problem on the download form.

Patrick Chevalley

19-03-02 11:07

administrator   ~0005447

Yes, the download dialog was not scaled.

This is fixed:
https://github.com/pchev/skychart/commit/1c22675d09b669f53e508176f2812d9fba6f4ce3

Issue History

Date Modified Username Field Change
19-02-02 16:47 Sasa New Issue
19-02-02 16:48 Sasa File Added: Screenshot from 2019-02-02 16-35-24.png
19-02-02 17:35 Patrick Chevalley Status new => assigned
19-02-02 17:35 Patrick Chevalley Target Version => 4.2
19-02-02 17:35 Patrick Chevalley Note Added: 0005293
19-02-02 17:55 Patrick Chevalley Note Added: 0005294
19-02-02 19:28 Patrick Chevalley Note Added: 0005296
19-02-02 20:15 Sasa Note Added: 0005297
19-02-02 20:16 Sasa Note Edited: 0005297
19-02-02 20:18 Sasa Note Edited: 0005297
19-02-02 20:46 Sasa Note Added: 0005298
19-02-02 20:52 Sasa Note Edited: 0005298
19-02-02 20:52 Sasa File Added: Screenshot from 2019-02-02 20-50-12.png
19-02-02 20:52 Sasa File Added: Screenshot from 2019-02-02 20-50-18.png
19-02-02 22:33 Patrick Chevalley Note Added: 0005299
19-02-02 23:38 Sasa File Added: Screenshot from 2019-02-02 23-30-34.png
19-02-02 23:38 Sasa Note Added: 0005300
19-02-03 16:38 Sasa Note Added: 0005313
19-02-03 16:39 Sasa File Added: Screenshot from 2019-02-03 16-37-34.png
19-02-03 17:04 Patrick Chevalley Note Added: 0005314
19-02-06 13:50 Patrick Chevalley Status assigned => resolved
19-02-06 13:50 Patrick Chevalley Resolution open => fixed
19-02-06 13:50 Patrick Chevalley Fixed in Version => 4.1 SVN
19-02-06 13:50 Patrick Chevalley Note Added: 0005339
19-02-26 21:45 Sasa Status resolved => new
19-02-26 21:45 Sasa Resolution fixed => reopened
19-02-26 21:45 Sasa Note Added: 0005443
19-02-27 16:20 Patrick Chevalley Assigned To => Patrick Chevalley
19-02-27 16:20 Patrick Chevalley Status new => resolved
19-02-27 16:20 Patrick Chevalley Resolution reopened => fixed
19-02-27 16:20 Patrick Chevalley Note Added: 0005444
19-03-02 07:13 Sasa Status resolved => new
19-03-02 07:13 Sasa Resolution fixed => reopened
19-03-02 07:13 Sasa Note Added: 0005446
19-03-02 11:07 Patrick Chevalley Status new => resolved
19-03-02 11:07 Patrick Chevalley Resolution reopened => fixed
19-03-02 11:07 Patrick Chevalley Note Added: 0005447